Bug #244: Deleting Chest Items
| ID | #244 |
|---|---|
| Submitter | Ryouken |
| Product | EOSERV |
| Severity | Normal |
| Status | CLOSED, FIXED |
| Submitted | 17th Apr 2013 |
| Updated | 31st Jan 2014 |
| Rev# | Date | Description |
|---|---|---|
| r386 | 31 Jan 2014 23:16:16 UTC | Better partial chest take code, fixes bug #244 |
11 years, 33 weeks ago
I noticed another bug in chests where you can delete the contents and not get them if you're overweight. The problem is it's only adding the deleted items back if taken is not 0, but if I were to send a packet to request those chest items and I'm overweight, then taken would obviously be 0 and the items would not be added back.
I suggest setting the amount inside the if(taken) scope to avoid deleting items and not putting those not taken back.
Comments
11 years, 33 weeks ago
Actually, that suggestion I made wouldn't work, this part should be taken out of the if(taken) scope and put above it right after the variables:
if (amount - taken > 0)
{
chest->AddItem(id, amount - taken);
}
11 years, 33 weeks ago
I wasn't aware the official EOSERV rev enforced weight...
11 years, 32 weeks ago
The variable taken acts as a boolean there because it will be given an amount 0(false) or >0(true). I suspect something is broken prior to this. I think the problem is checking the character->weight to character->maxweight. I think I had changed something in these because Sausage allowed weight = maxweight to not be considered overweight in places. I will check the official code again, but I think that is the actual problem.
11 years, 30 weeks ago
Good catch. =]
Updated Status to CONFIRMED
10 years, 43 weeks ago
Fixed in r386
Updated Status to CLOSED, FIXED
Add Comment
Please don't post unless you have something relevant to the bug to say.
Do not comment to say "thanks" or "fix this please".
Please log in to add comments. EOSERV Bug Tracker > Bug #244: Deleting Chest Items