Bug #17: Citizen deny packet
| ID | #17 |
|---|---|
| Submitter | Hollows |
| Product | EOSERV |
| Severity | Feature Request |
| Status | CLOSED, FIXED |
| Submitted | 4th Sep 2012 |
| Updated | 6th Sep 2012 |
| Rev# | Date | Description |
|---|---|---|
| r321 | 06 Sep 2012 18:53:28 UTC | Fix bug #17 |
| r322 | 06 Sep 2012 20:30:43 UTC | Actually fix bug #17! Can no longer subscribe to towns if you're already subscribed to one. |
| r323 | 06 Sep 2012 20:54:13 UTC | Fix bug #17 for the last time..., Add CitizenSubscribeAnytime and CitizenUnsubscribeAnywhere ... |
11 years, 38 weeks ago
I would like to see a citizen deny packet in one of the next releases! I've been trying to find it for a while, but no success yet. This packet should tell you that you're already a member of a certain citizen when you attempt to do the subscribe test. Instead of allowing you to join other citizens when you haven't left the current one.
Comments
11 years, 38 weeks ago
Updated Status to CONFIRMED
11 years, 38 weeks ago
Identified! In CITIZEN OPEN the packet structure as logged from EO main:
Three(1); //possibly useless.
Char(bool); //false unless has citizenship, reply will load if true.
Char(165); //useless value loaded from main.
Char(161); //again useless.
Byte(255);
BreakString(question);
BreakString(question);
BreakString(question);
11 years, 38 weeks ago
Comment above order is misplaced do to some post submission bug. I typed it in this order: Three(1)/Char(bool)/Char(165)/Char(161)/BreakString(question)/BreakString(question)/BreakString(question).
11 years, 37 weeks ago
Fixed in r321
Updated Status to CLOSED, FIXED
11 years, 37 weeks ago
I've added the fix of revision 321 however, when I'm already a member of a certain citizen I can still sign up to become a citizen. Even after I've answered the questions it won't stop me of joining.
11 years, 37 weeks ago
You're right, this is a much more fundamental problem. I'm surprised that the update did that rather than completely locking you out of subscribing at all though. The Home structure needs to store the ID of the innkeeper for a given home ID.
Updated Status to OPEN, CONFIRMED
11 years, 37 weeks ago
Okay, really fixed this time, r322. =]
Updated Status to CLOSED, FIXED
11 years, 37 weeks ago
Worth noting that if your innkeeper NPC doesn't have a vendor ID set, this problem will still occur.
11 years, 37 weeks ago
Err, one more oopsie. Can't subscribe at all, will be fixed in r323, along with the above...
11 years, 37 weeks ago
I see that it blocks it, thank you but does this also include the box saying "You cannot take this test because you're already member of a town" or something like that? Just like MainEO. inb4 thanks
11 years, 37 weeks ago
Yes. That's handled by the client when it sees that you're a citizen of a town already.
What it doesn't do is stop you from trying to subscribe twice without closing the window in-between, which can't be fixed.
Add Comment
Please don't post unless you have something relevant to the bug to say.
Do not comment to say "thanks" or "fix this please".
Please log in to add comments. EOSERV Bug Tracker > Bug #17: Citizen deny packet