EOSERV Bug Tracker > Bug #132: Quest GotItems problem

Bug #132: Quest GotItems problem

Quest GotItems problem
ID #132
Submitter AustinB
Product EOSERV
Severity Critical
Status CLOSED, FIXED
Submitted 20th Sep 2012
Updated 21st Sep 2012
Related SVN Revisions
Rev# Date Description
r350 21 Sep 2012 17:16:16 UTC Check quest rules after re-calculating stats (bug #132)
AustinB Submitter 12 years, 15 weeks ago

I currently have it set to:

rule GotItems(248,10) goto GotClaws

Now that I have that out there, here's the bug.

When I go in-game and I get to this quest state, if I have more than "10" of that item, it won't register as I have 10 items. You have to have exactly 10 in your inventory for it to work.

  • sorry if this was already posted, I looked and didn't see it*

Comments

Sausage Developer 12 years, 15 weeks ago

Can't reproduce this, using this test quest: http://tehsausage.com/paste/7130

Do you have any more info on the way you're triggering it?

Updated Severity to NORMAL

AustinB Submitter 12 years, 15 weeks ago

It's not just if you have more than 10. I have 10 claws and the quest won't move on. I'll post the full quest now:

http://pastebin.com/4dNrmE46

AustinB Submitter 12 years, 15 weeks ago

Sorry for double post but:

I found that if you relog, then the quest will move on, no matter if you have 10+ claws or whatever.

Hollows 12 years, 15 weeks ago

I'm not completely sure what's the cause, but I have a problem with GotItems as well. When I have 21 of them (21/20) it won't go to the next state. Although when I look into the source it does say ">=". Then again I'm not completely sure what's the cause but I have the same problem as Austin.

Apollo 12 years, 15 weeks ago

Can you confirm if dropping an item and picking it back up cause the state to move?

Apollo 12 years, 15 weeks ago

Solved. The reason it doesn't work is because there is no CheckQuestRules() for character's AddItem/DeleteItem booleans. Find those in the character.cpp file and add this->CheckQuestRules(); just after this->CalculateStats(); for both cases. Otherwise, taking 1 step in any direction on the map will trigger a quest rule check (not as logical, but it is a temp fix). I would suggest putting this in for spells as it probably has the same bug.

Sausage Developer 12 years, 15 weeks ago

I think there is definitely supposed to be call to CheckQuestRules() in CalculateStats(). It looks like this was accidentally removed in r291.

Upping the severity since this seriously breaks quests which depend on GotItem/LostItem.

Updated Severity to CRITICAL
Updated Status to CONFIRMED

Sausage Developer 12 years, 15 weeks ago

One-line addition to fix it in r350.

Updated Status to CLOSED, FIXED

Add Comment

Please don't post unless you have something relevant to the bug to say.
Do not comment to say "thanks" or "fix this please".

Please log in to add comments. EOSERV Bug Tracker > Bug #132: Quest GotItems problem