Bug Tracker :: View Report

This became evident to me when I was rewriting $remap to support mass/ranged/remote reloading of maps.

In the Map::Reload() function, you will find an if statement that checks whether the map needs to be reloaded. This is the root of the problem.

std::FILE *fh = std::fopen(filename.c_str(), "rb");

if (!fh)

{

Console::Err("Could not load file: %s", filename.c_str());

return false;

}

SAFE_SEEK(fh, 0x03, SEEK_SET);

SAFE_READ(checkrid, sizeof(char), 4, fh);

if (this->rid[0] == checkrid[0] && this->rid[1] == checkrid[1]

&& this->rid[2] == checkrid[2] && this->rid[3] == checkrid[3])

{

return true;

}

As you can see, EOSERV opens the map file - But if the map doesn't need to be reloaded, the function returns true without closing the map (fh).

This created quite a headache for me, before I realized what the problem was.