EOSERV Bug Tracker > Bug #318: GenerateCharacterID() function not capped

Bug #318: GenerateCharacterID() function not capped

GenerateCharacterID() function not capped
ID #318
Submitter Plasmastar
Product EOSERV
Severity Normal
Status CLOSED, INVALID
Submitted 28th Jan 2015
Updated 30th Jan 2015
Plasmastar Submitter 9 years, 14 weeks ago

int World::GenerateCharacterID()

{

return ++this->last_character_id;

}

This is only an issue because trade setups use this ID as a Short and it is feasible to overflow it. Feasible...but still does need time.

As such, trades cease to function as normal because the client will have read the Short and gotten the wrong ID.

Comments

Plasmastar Submitter 9 years, 14 weeks ago

Note: I haven't checked to see where else this ID is used at. :(

Sausage Developer 9 years, 14 weeks ago

Overflow only feasibly affects trades which use the ID mistakenly.

See bug #319.

Updated Status to CLOSED, INVALID

Add Comment

Please don't post unless you have something relevant to the bug to say.
Do not comment to say "thanks" or "fix this please".

Please log in to add comments. EOSERV Bug Tracker > Bug #318: GenerateCharacterID() function not capped