EOSERV Bug Tracker > Bug #316: Items locked in a trade window can be removed via quests

Bug #316: Items locked in a trade window can be removed via quests

Items locked in a trade window can be removed via quests
ID #316
Submitter Sausage
Product EOSERV
Severity Normal
Status OPEN, CONFIRMED
Submitted 13th Jan 2015
Updated 13th Jan 2015
Sausage Submitter
Developer 9 years, 16 weeks ago

Quest RemoveItem actions can potentially delete items that are currently locked in a trade window, resulting in scamming.

Comments

DanScott 9 years, 16 weeks ago

surely it's just a case of if (!this->character->trading) on like 579 just after "else if (function_name == "removeitem")" in quest.cpp, should be a work around for it as well as stopping the quest progression if the character is trading?

Apollo 9 years, 16 weeks ago

All quest actions are evaluated when entering a new quest state. Telling the quest to simply not remove an item if character is in trade will do simply that, which would allow a player to evade giving up quest items. A better solution might be to check if the character is in fact trading, and then pulling any quest item from the trade window if it is part of a quest remove item action.

DanScott 9 years, 15 weeks ago

That's why I suggested stopping the quest progression also :P but yeah your solution is better all round ^_^

Add Comment

Please don't post unless you have something relevant to the bug to say.
Do not comment to say "thanks" or "fix this please".

Please log in to add comments. EOSERV Bug Tracker > Bug #316: Items locked in a trade window can be removed via quests