EOSERV Bug Tracker > Bug #314: Signed integer overflow checks may be optimized out

Bug #314: Signed integer overflow checks may be optimized out

Signed integer overflow checks may be optimized out
ID #314
Submitter Sausage
Product EOSERV
Severity Critical
Status CLOSED, FIXED
Submitted 12th Jan 2015
Updated 13th Jan 2015
Sausage Submitter
Developer 9 years, 50 weeks ago

A few signed integer overflow checks in the form of c = a + b; if (c < a) ...; (e.g. Bank_Add in handlers/Bank.cpp) may be optimized out by the compiler, leading to potentially critical vulnerabilities.

Checks need to be replaced or the code compiled with -fwrapv.

Comments

Sausage Submitter
Developer 9 years, 50 weeks ago

Fixed in r443 by adding the compiler flag to allow signed overflow.

Updated Status to CLOSED, FIXED

Add Comment

Please don't post unless you have something relevant to the bug to say.
Do not comment to say "thanks" or "fix this please".

Please log in to add comments. EOSERV Bug Tracker > Bug #314: Signed integer overflow checks may be optimized out