Bug #269: CanHoldItems broken immediately following stat reset
ID | #269 |
---|---|
Submitter | Apollo |
Product | EOSERV |
Severity | Normal |
Status | CLOSED, DUPLICATE |
Submitted | 15th Nov 2013 |
Updated | 31st Jan 2014 |
Best example of this is uncommon, but a character can place an item in a chest, reset stats causing character overweight, then immediately taking an item from the chest. At this point the item appears to not be taken. Reopening a chest show the item was removed but has disappeared entirely since the character could not technically carry it. Also, it might be important to check that boolean for weight >= maxweight rather than simply weight > maxweight.
Comments
I remember finding this and fixing it a while back, but I can't remember if I ever got to making a bug report for it. I think I did though. o.o
Ah, here it is I think. http://eoserv.net/bugs/view_bug/244
I think it may be a bit different in this case as following a stat reset it seems that the player doesn't get the items, however the function continues to process server-side removing the item from the chest. The function should be killed immediately to prevent this. I put a simple weight >= maxweight check at the start to stop this. In other words the weight/maxweight check is breaking the chest drop with the fix applied. Probably poor labeling on my part since the bug is referenced already, but worth keeping this as a seperate issue due to a failed check in chest take following a stat reset based on the assumption I fixed CanHoldItems previously.
Updated Status to CLOSED, DUPLICATE
Add Comment
Please don't post unless you have something relevant to the bug to say.
Do not comment to say "thanks" or "fix this please".
Please log in to add comments. EOSERV Bug Tracker > Bug #269: CanHoldItems broken immediately following stat reset