EOSERV Bug Tracker > Bug #176: HP and TP can be unsigned

Bug #176: HP and TP can be unsigned

HP and TP can be unsigned
ID #176
Submitter Ryouken
Product EOSERV
Severity Normal
Status OPEN, CONFIRMED
Submitted 15th Nov 2012
Updated 15th Nov 2012
Ryouken Submitter 12 years, 7 weeks ago

I was wondering why hp and tp are signed when the client uses them as unsigned shorts. If hp is signed and too high, it can instantly kill you when hit. Having them unsigned would keep this from happening I would think. o.o

Comments

Sausage Developer 12 years, 7 weeks ago

In most cases non-single-byte values are treated as signed by the client (even though negative numbers are never used in EO; fun fact), so EOSERV follows that. The maximum stat values EOSERV can enforce should be used to keep users from going anywhere near overflowing hp or damage values, if you're getting numbers that big, changing to unsigned will only double the range before you start seeing anomalies, so you should be aiming to keep your hp/damage values well below 10,000 if you want to give yourself breathing room.

Will investigate to see if unsigned values can be used in some places to match the client better, and/or do something a little more sane in the case of overflow.

Updated Status to CONFIRMED

Add Comment

Please don't post unless you have something relevant to the bug to say.
Do not comment to say "thanks" or "fix this please".

Please log in to add comments. EOSERV Bug Tracker > Bug #176: HP and TP can be unsigned